Closed irieger closed 4 months ago
Thanks for looking into this. I set CMAKE_CXX_STANDARD
to 20 in the libMXF and libMXF++ libraries as well and found one more issue with a missing include - see below. If you could add that one as well please then it should all be good.
--- a/deps/libMXFpp/libMXF++/MXFVersion.cpp
+++ b/deps/libMXFpp/libMXF++/MXFVersion.cpp
@@ -33,6 +33,8 @@
#include "config.h"
#endif
+#include <string>
+
#include "git.h"
#include "fallback_git_version.h"
Thanks for looking into this. I set
CMAKE_CXX_STANDARD
to 20 in the libMXF and libMXF++ libraries as well and found one more issue with a missing include - see below. If you could add that one as well please then it should all be good.--- a/deps/libMXFpp/libMXF++/MXFVersion.cpp +++ b/deps/libMXFpp/libMXF++/MXFVersion.cpp @@ -33,6 +33,8 @@ #include "config.h" #endif +#include <string> + #include "git.h" #include "fallback_git_version.h"
Sure, just added it. And with your hint also changed our patches for Conan to comment out set(CMAKE_CXX_STANDARD 11)
also for the deps and tried it with that patch.
Add a compatibility fix for C++20 (and maybe others) to fix a non-supported conversion from std::string_view to std::string.
When preparing a recipe for the Conan package manager to properly add bmx as a dependency in other projects. One of the points there is to honor the user request for the C++ version requested by the user, thus I patch out the fixed setting of C++11. (See corresponding PR: https://github.com/conan-io/conan-center-index/pull/23955)
With C++20 set, I got the following error requiring an implicit conversion: