add HOST config, this allows to listen on other interfaces

bbc / brave

Basic Real-time AV Editor - allowing you to preview, mix, and route live audio and video streams on the cloud

Apache License 2.0

654 stars 148 forks source link

add HOST config, this allows to listen on other interfaces #14

Closed lucasdavila86 closed 5 years ago

lucasdavila86 commented 5 years ago

Today brave only listen on localhost:PORT. This change will allow the user to listen on another interface even on 0.0.0.0. Listening on 0.0.0.0 helps to EXPOSE the port on a docker container.

moschopsuk commented 5 years ago

Thanks for the PR! Yep this is a scenario we never considered, but worth addressing.

lucasdavila86 commented 5 years ago

I've created a Dockerfile for running brave on a container. It is working, at least I was able to create a rtmp output and mix a test input and a overlay. Are you interested? I can create a pull request on this