search

bbc / brave

Basic Real-time AV Editor - allowing you to preview, mix, and route live audio and video streams on the cloud
Apache License 2.0
654 stars 148 forks source link

brave fails to start on ubuntu 18.10 #15

Closed lucasdavila86 closed 5 years ago

lucasdavila86 commented 5 years ago

After installing all the dependencies on ubuntu 18.10 I was unable to start brave. This error shows up: Missing gstreamer plugins: ['faac']

I was reading about the ubuntu packages and seems they dropped the faac support on the gstreamer bad plugins, maybe in favor of avenc_aac, avdec_aac (these ones are supported, see below)

gst-inspect-1.0 | grep aac
libav:  avenc_aac: libav AAC (Advanced Audio Coding) encoder
libav:  avdec_aac: libav AAC (Advanced Audio Coding) decoder
libav:  avdec_aac_fixed: libav AAC (Advanced Audio Coding) decoder
libav:  avdec_aac_latm: libav AAC LATM (Advanced Audio Coding LATM syntax) decoder
libav:  avmux_adts: libav ADTS AAC (Advanced Audio Coding) muxer (not recommended, use aacparse instead)
audioparsers:  aacparse: AAC audio stream parser
typefindfunctions: audio/aac: aac, adts, adif, loas
voaacenc:  voaacenc: AAC audio encoder
matthew1000 commented 5 years ago

Thanks @lucasdavila86 good spot.

I did a search and replace on faac --> avenc_aac but the pipeline failed so it'll need a bit further digging. I'll get on it.

lucasdavila86 commented 5 years ago

Found a bug report about 'faac' support on gst-plugins-bad. It's quite old, ~2014 https://bugs.launchpad.net/ubuntu/+source/gst-plugins-bad1.0/+bug/1299376

matthew1000 commented 5 years ago

OK, we have a pull request https://github.com/bbc/brave/pull/17 to remove all faac usage... which can now go in to master.

moschopsuk commented 5 years ago

@lucasdavila86 I'm going to close this issue, please feel to reopen if this is still an issue.