search

bbc / brave

Basic Real-time AV Editor - allowing you to preview, mix, and route live audio and video streams on the cloud
Apache License 2.0
656 stars 149 forks source link

FYI: Docker base system ubuntu 18.10 creates an error, maybe update? #58

Open michael-riha opened 4 years ago

michael-riha commented 4 years ago

Hello Gentlemen,

first of all, I love your project and I will fork it in the future since I started from a greenfield with the same approach which makes, now in the end hardly sense, to invent the wheel again.

As I am using Docker and I wanted to build your Container today I found that since a few days apt packages are not maintained anymore for Ubuntu 18.10, so maybe this would be a good opportunity to upgrade?

E: The repository 'http://archive.ubuntu.com/ubuntu cosmic Release' does not have a Release file.

dromer commented 4 years ago

The 18.10 release image is officially not supported any more: https://hub.docker.com/_/ubuntu

Better change it to something more current (hopefully 20.04 will be stable soon, then that should be a decent target)

matthew1000 commented 4 years ago

Hi Michael, great you like the project. Priorities have changed and we're not working on it as much as we'd like to, but hopefully that will change at some point.

Yep agreed moving to 20.4 when it launches will make a lot of sense.

dromer commented 4 years ago

Btw I tried 20.04 which comes with python3.8 by default.

Seems a big review of the pipenv is needed and possibly some refactoring (it didn't exactly "work as expected").

matthew1000 commented 4 years ago

Good to know, thanks. I'll try and find some time to give it a go.

Python & pipenv is never easy!

dromer commented 4 years ago

Honestly I prefer a decent requirements.txt or setup.py (pip install brave anyone?) :#

dromer commented 4 years ago

Actually it was fixed by installing libjpeg-dev (needed by pillow).