search

bbc / brave

Basic Real-time AV Editor - allowing you to preview, mix, and route live audio and video streams on the cloud
Apache License 2.0
656 stars 149 forks source link

Bad form for value comparison #62

Open dromer opened 4 years ago

dromer commented 4 years ago

All over the code we find examples like:

https://github.com/bbc/brave/blob/b9c8e194e0d409b80269d051087a2aeb45e82f38/brave/inputoutputoverlay.py#L137

Here value comparison is actually written as object comparison. This is clearly wrong. Such statements should be written with == and != not with is and is not.

moschopsuk commented 3 years ago

Happy for any PRs to address this 🙂

I've not had much free time recently to go over and address these.