search

bbc / brave

Basic Real-time AV Editor - allowing you to preview, mix, and route live audio and video streams on the cloud
Apache License 2.0
653 stars 148 forks source link

Added fixes for docker #63

Open medcelerate opened 4 years ago

medcelerate commented 4 years ago

Fixed the dockerfile and added the requirements txt file. All requirements added to requirements.txt

dromer commented 4 years ago

Can I ask why you are using conda? (I find conda 1) bloated and 2) does OS-level things that it really shouldn't). Why not virtualenv, pyenv or pipenv?

medcelerate commented 4 years ago

We’ve been using it in our prod system at work and in this case when building the container it just worked. Pipenv threw a number of install errors that weren’t easily fixable and I’ve been well adept at working and building conda ebbs for projects with version specific binary dependencies.

On Wed, Apr 8, 2020 at 12:06 PM dromer notifications@github.com wrote:

Can I ask why you are using conda? (I find conda 1) bloated and 2) does OS-level things that it really shouldn't). Why not virtualenv, pyenv or pipenv?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bbc/brave/pull/63#issuecomment-611046875, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHYKRGO2ONGKA2ZU7KPU5DTRLSOHNANCNFSM4LRO46WQ .

dromer commented 4 years ago

Conda does way too much "automagic" to my liking (and tends to do many things "the wrong way" too). Imo it's better to do things more explicitly (and deterministically) then to have conda do things for you.

In this case it's only about installing dependencies from pip no? A virtualenv should suffice I'd say.

medcelerate commented 4 years ago

I was using virtualenv and pipenv and neither would build properly.

dromer commented 4 years ago

Then you are doing it wrong? :)