search

bbc / digital-paper-edit-client

Work in progress - BBC News Labs digital paper edit project - React Client
https://bbc.github.io/digital-paper-edit-client
Other
45 stars 13 forks source link

Unable to play audio in Paper Edit view #117

Closed leihelondon closed 3 years ago

leihelondon commented 3 years ago

Issue: Clicking on the play button in the Programme Script view on the right doesn't play audio.

To replicate: Sign in as admin and go to the follow links and click the play button in the Programme Script view on the right https://digital-paper-edit.test.tools.bbc.co.uk/#/projects/486aMNX8J6xHazceIicY/paperedits/8bm9IS4OdJSLpu7IJWVY https://digital-paper-edit.test.tools.bbc.co.uk/#/projects/MBjdsSOVTlB5v7VdJf2C/paperedits/y5NC4fyrDnoi6ugZLZi7

Screen Shot 2021-05-27 at 16 29 57
allishultes commented 3 years ago

FYI I have tested this on my end, on the test environment, with a .wav and a .mp3 that I uploaded yesterday. Both play back. @leihelondon I'll try to find this project in the screenshot but if you have examples that aren't working that would be helpful!

See: https://digital-paper-edit.test.tools.bbc.co.uk/#/projects/486aMNX8J6xHazceIicY/paperedits/pDrXCm3YlYHT7lAuuLgx

leihelondon commented 3 years ago

FYI I have tested this on my end, on the test environment, with a .wav and a .mp3 that I uploaded yesterday. Both play back. @leihelondon I'll try to find this project in the screenshot but if you have examples that aren't working that would be helpful!

See: https://digital-paper-edit.test.tools.bbc.co.uk/#/projects/486aMNX8J6xHazceIicY/paperedits/pDrXCm3YlYHT7lAuuLgx

Just updated the ticket.

allishultes commented 3 years ago

Both programme scripts linked to above use expired and/or deleted media content. From looking into this, I believe that if any of the media files referenced in the paper edit do not exist, none of the media will play in the preview.

Re: https://digital-paper-edit.test.tools.bbc.co.uk/#/projects/MBjdsSOVTlB5v7VdJf2C/paperedits/y5NC4fyrDnoi6ugZLZi7

Screenshot 2021-05-27 at 11 10 03

Only the "Roland Hughes" file was not expired. When I created a new programme script in this project, and only made selections from this transcript, the media played back perfectly (see link).

Re: https://digital-paper-edit.test.tools.bbc.co.uk/#/projects/486aMNX8J6xHazceIicY/paperedits/8bm9IS4OdJSLpu7IJWVY

The programme script referenced a deleted media file, and therefore did not play back (this would've been confusing to debug as everything I've uploaded in this project has the same name).

To test whether it would play back the files that do exist, I tried adding a new paper-cut segment to this project, from a transcript that had its media stored still. It still did not play back, which is why I believe the playback function will not work if any of the files are expired.

Suggestion: we should clean up test so that we aren't diagnosing bugs that likely won't effect users doing an under-60-day trial. I can also add some notes about this to the user manual.

allishultes commented 3 years ago

See: https://paper.dropbox.com/doc/latest-Manual-DPE-Digital-Paper-Edit--BLiz_tGlpUjNCLvYf~RGcHLfAg-wd9c7c4Du0etP4m6tp3VD#:h2=Reference-/-FAQ. I believe this issue can be closed.