search

bbc / digital-paper-edit-electron

Work in progress - BBC News Labs digital paper edit project - Electron, Cross Platform Desktop app - Mac, Windows, Linux
Other
26 stars 22 forks source link

Won't build on Travis CI via commits to master #6

Open emettely opened 5 years ago

emettely commented 5 years ago

Describe the bug (it's designed this way)

  1. I push to master via the command line.
  2. Travis CI is triggered to build with my user's creds
  3. Won't build because the token is different.
  4. Silently fails (no reason given, other than 10 mins of unresponsiveness)

To Reproduce Steps to reproduce the behavior: See above.

Expected behavior Would expect pushing to master to build (at least for me). Is there a way to add multiple credentials? https://stackoverflow.com/a/48970546

Screenshots

Additional context https://travis-ci.org/bbc/digital-paper-edit-electron/builds/595003442

emettely commented 5 years ago

As a side note, the npm run build doesn't build locally on my laptop.

pietrop commented 5 years ago

Just to clarify, In the current setup the reason why it doesn't build on travis is because the github token is not your personal one?

As if you commit to master from the github UI the build works?

emettely commented 5 years ago

I think they are completely separate things, that I thought stems from the same issue.

pietrop commented 5 years ago

so is this the issue?

Is there a way to add multiple credentials?

emettely commented 5 years ago

For the Travis build only :)