search

bbc / grandstand

BBC Grandstand is a collection of common CSS abstractions and utility helper classes
http://bit.ly/grandstandcss
MIT License
191 stars 9 forks source link

Updates Tamil, Sinhala and Bengali font sizes to UX specification #100

Closed pvaliani closed 3 years ago

pvaliani commented 3 years ago

This pr updates font configurations for Bengali, Tamil and Sinhala services relating to the following issue:

https://github.com/bbc/simorgh/issues/9435

Font size UX specification info (request for access): https://docs.google.com/spreadsheets/d/1ZXxajDkmbenCdYWtTBkDogRqi9a3-O4tsXUK7nvDrWU/edit#gid=771505033

benswatson commented 3 years ago

Does this need a version bump?

https://github.com/bbc/grandstand/blob/master/bower.json#L20 https://github.com/bbc/grandstand/blob/master/package.json

pvaliani commented 3 years ago

Does this need a version bump?

https://github.com/bbc/grandstand/blob/master/bower.json#L20 https://github.com/bbc/grandstand/blob/master/package.json

yes good spot. Have updated in a new commit!

benswatson commented 3 years ago

Does this need a version bump? https://github.com/bbc/grandstand/blob/master/bower.json#L20 https://github.com/bbc/grandstand/blob/master/package.json

yes good spot. Have updated in a new commit!

Thanks! Is package.json's version field redundant with bower.json?

HarveyPeachey commented 3 years ago

Does this need a version bump? https://github.com/bbc/grandstand/blob/master/bower.json#L20 https://github.com/bbc/grandstand/blob/master/package.json

yes good spot. Have updated in a new commit!

Thanks! Is package.json's version field redundant with bower.json?

Nope, I've now updated the package.json @benswatson