search

bbc / grandstand

BBC Grandstand is a collection of common CSS abstractions and utility helper classes
http://bit.ly/grandstandcss
MIT License
191 stars 9 forks source link

[WIP] Update Faux Block Link to News Implementation #42

Closed dgm34 closed 8 years ago

dgm34 commented 8 years ago

Following on from https://github.com/bbc/morph-modules/pull/4629 and https://github.com/bbc/morph-modules/pull/4664 this updates GS to use the News implementation of faux block links.

See http://codepen.io/anon/pen/NAwZpd

Please don't merge this yet! 😄

dgm34 commented 8 years ago

I wonder if there's bits of this (i'm thinking the <IE9 bits) that should be kept.

It'd be good to hear your thoughts @greenc05 ? 🍰

shaunbent commented 8 years ago

Missing a bump of the package.json and bower.json.

Will need to be a major bump as this is a breaking change.

dgm34 commented 8 years ago

I've bumped the major version for 4.0.0 to reflect this being a breaking change. I've tidied up the example too.

dgm34 commented 8 years ago

We're going to give this a good test using the News implementation in https://github.com/bbc/morph-modules/pull/4629 and https://github.com/bbc/morph-modules/pull/4664 and we'l get back to you about this @shaunbent 👍

dgm34 commented 8 years ago

I think we'll need to backport these enhancements too https://github.com/bbc/morph-modules/pull/4830

dgm34 commented 8 years ago

And it relies on conditional copmments like this always being available: https://github.com/bbc/euler-site-descriptions/pull/55/files

dgm34 commented 8 years ago

@sareh has kindly agreed to integrate this in to https://github.com/bbc/grandstand/pull/54/files 👍 🍰