search

bbc / grandstand

BBC Grandstand is a collection of common CSS abstractions and utility helper classes
http://bit.ly/grandstandcss
MIT License
191 stars 9 forks source link

Typography and RTL overrides for non-latin scripts #44

Closed jamesdonoh closed 8 years ago

jamesdonoh commented 8 years ago

The typographic overrides here are derived from https://github.com/BBC-News/responsive-news/blob/develop/tabloid/webapp/static/sass/tools/_rtl.scss

The rationale for overriding typography in this module rather than at a lower level was to keep gel-typography for 'true' GEL styles.

To date we have not generated any overrides for latin-diacritics or arabic-pashto which RN had, because of doubts about whether they are needed.

The unfortunate use of lots of @if statements in separate files is because SASS doesn't allow @import inside @if, nor variable interpolation inside @import.

An example of this being used (in a Morph module) is: https://github.com/bbc/morph-modules/pull/4640

Jira ticket: WSRESPONSIVE-4349

jamesdonoh commented 8 years ago

@stefano-belloro @shaunbent @mintuz can I have some feedback on this please?

shaunbent commented 8 years ago

Looks good to me, happy with this approach.

Just the one question.