Closed sareh closed 4 years ago
👀
Hello @sareh is this issue now solved with the different variants defined here. https://github.com/bbc/grandstand/tree/master/src Just wanting to understand the problem a little further, the first two tasks you defined it feels like we already have these in place and is only the 3rd bullet point we need to try and solve?
Currently, Grandstand only has the CSS for latin script, used by the English language BBC sites.
The BBC News uses Grandstand and it has almost 30 other World Service sites in various languages.
Here is a map of BBC sites to their scripts:
Glossary
Service
is what we call each of the different sites. e.g. http://www.bbc.co.uk/arabic is the Arabic service.Tasks
_bbc-service.scss
file._bbc-service.scss
files have the relevant variables, e.g._bbc-pashto.scss
should have$script: 'arabic';
and most likely a scaling value for the font size & line height, inrem
.line-height
andfont-size
for each individualtype
(e.g.gel-trafalgar
).e.g. in the file https://github.com/BBC-News/responsive-news/blob/develop/tabloid/webapp/static/sass/objects/_typography.scss, we have code that overrides the typography
We can look at this for Typography: https://github.com/bbc/gel-typography/blob/master/lib/_settings.scss