search

bbc / grandstand

BBC Grandstand is a collection of common CSS abstractions and utility helper classes
http://bit.ly/grandstandcss
MIT License
191 stars 9 forks source link

Add ethiopic script for amharic and tigrinya #82

Closed alex-magana closed 7 years ago

alex-magana commented 7 years ago

Add ethiopic script for use in amharic and tigrinya.

PR - ws-alephamp-queue-renderer WS2020-578

pjlee11 commented 7 years ago

This will also need a version bump :)

alex-magana commented 7 years ago

Hello @sareh The reason for creating the placeholder was to avoid having unused CSS loading, for services that utilize custom fonts and have latin set as a placeholder script type. I'll look into how we can use the shared script type while avoiding having to create placeholder scripts. Allow us in the meantime, to have this here for the purpose indicated above, of loading the required custom fonts. Thanks

sareh commented 7 years ago

@andela-amagana Thanks for your reply, Alex. These script versions pull in all the code for the Latin version plus the script-specific overrides. So, if there are no overrides at all and you are using a custom font, you could just use the latin version of Grandstand on your page.

I've also noticed your new PR to replicate this work for the Gujarati script: https://github.com/bbc/grandstand/pull/84 and your comment on this JIRA ticket

We can use the Latin version of Grandstand on multiple sites. News and Sport currently use it for pages. You can use it for Gujarati, Amharic and Tigrinya sites too.