bbc / http-transport-cache

A HTTP spec compliant caching layer for http-transport.
Other
3 stars 5 forks source link

travis.yml and minimum engine mismatch #26

Closed niklasR closed 5 years ago

niklasR commented 5 years ago

Travis runs tests in the latest version of node 8 as minimum: https://github.com/bbc/http-transport-cache/blob/212bb0339ef79586cb77fa052e7e103a997a8bea/.travis.yml#L6

The package.json specifies v4.0.0 as minimum: https://github.com/bbc/http-transport-cache/blob/212bb0339ef79586cb77fa052e7e103a997a8bea/package.json#L12

assert.doesNotReject and assert.rejects were only added in 8.13.0, so tests may fail on versions that the the package.json allows, but this would not be flagged by Travis.

davidc6 commented 5 years ago

Fixed in https://github.com/bbc/http-transport-cache/pull/27

nspragg commented 5 years ago

@davidc6 - thanks 👍