[Fix] Fixing logic around string matching and new tests - Githubissues

bbc / lrud

Left, Right, Up, Down. A spatial navigation library for devices with input via directional controls.

Apache License 2.0

98 stars 21 forks source link

[Fix] Fixing logic around string matching and new tests #22

Closed thomascgray closed 5 years ago

thomascgray commented 5 years ago

Description

We had some wonky logic around string matching when handling internal pathing.

This has been fixed.

Motivation and Context

Fixes #21

How Has This Been Tested?

New tests

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

thomascgray commented 5 years ago

@jordanholt excellent spot - I've done more some fixes and added a new test ensures both path lists are consistent when unregistering a node that has focusable children