LRUD not outputting ES5 or including polyfills.

bbc / lrud

Left, Right, Up, Down. A spatial navigation library for devices with input via directional controls.

Apache License 2.0

98 stars 21 forks source link

LRUD not outputting ES5 or including polyfills. #47

Closed edmorrish closed 4 years ago

edmorrish commented 5 years ago

Describe the bug

LRUD targets ES5 but uses ES6 features (Array.prototype.find, String.prototype.includes). Typescript should be checking for usage of features at a newer version but isn't. Alternatively we should be including polyfills.

To Reproduce tsc runs without error

Expected behavior tsc should complain that we're using es6 features

edmorrish commented 4 years ago

I think this problem is caused by having a devdependency on rollup-plugin-commonjs. This is deeply cursed so I'm investigating more, but removing the module from package.json seems to solve the problem.....

edmorrish commented 4 years ago

Or maybe it's just rollup???? this is extremely confusing but by removing rollup or rollup plugins from the package.json and doing npm i you can get the errors to re-appear.

edmorrish commented 4 years ago

https://github.com/rollup/rollup/issues/3224

edmorrish commented 4 years ago

Resolved