Uncaught RangeError: Maximum call stack size exceeded

[adrian-wozniak]

Describe the bug If the navigation tree has node with id 'undefined' (string containing 9 chars word) then climbUp method fails with Maximum call stack size exceeded when no focus candidates found.

When the root node is reached than climbing should stop but apparently it jumps (climbs up) to node with id 'undefined', and continue climbing, until root node is reached again, and again, and again, until call stack size is exceeded.

To Reproduce

const navigation= new Lrud()

navigation.registerNode('root', { orientation: 'horizontal' })
navigation.registerNode('undefined', { parent: 'root', isFocusable: true })

navigation.assignFocus('undefined')

navigation.handleKeyEvent({ direction: 'right' });

Expected behavior Handling key event should be stopped and currently focused node should stay focused.

Additional context On more complicated navigation trees it may happen than, before exceeding call stack size, focus suddenly jumps to node with id 'undefined'. Similar issue is for node with id 'null'. Additional side effects of this bug:

• navigation.assignFocus() - assigns focus to 'undefined' node.
• navigation.assignFocus(null) - assigns focus to 'null' node.
• navigation.pickNode() - unregisters 'undefined' node.
• navigation.pickNode(null) - unregisters 'null' node.
• etc...