mediaUrl required in setSource options in TypeScript?

bbc / peaks.js

JavaScript UI component for interacting with audio waveforms

https://waveform.prototyping.bbc.co.uk

GNU Lesser General Public License v3.0

3.2k stars 279 forks source link

mediaUrl required in setSource options in TypeScript? #384

Closed noaLeibman closed 3 years ago

noaLeibman commented 3 years ago

Hi! I have the latest version (0.25.0) installed in a TypeScript project. I saw that the mediaUrl property is still required on SetSourceRequiredOptions even though this was changed before, was peaks.js.d.ts not updated? Thanks:)

chrisn commented 3 years ago

It seems that way, thanks for reporting this. (I need a better way of updating and testing the TypeScript definitions, it's a constant source of issues...)