Fix overviewHighlightColor, update .d.ts

bbc / peaks.js

JavaScript UI component for interacting with audio waveforms

https://waveform.prototyping.bbc.co.uk

GNU Lesser General Public License v3.0

3.2k stars 279 forks source link

Fix overviewHighlightColor, update .d.ts #394

Closed jdelStrother closed 3 years ago

jdelStrother commented 3 years ago

overviewHighlightColor stopped working in https://github.com/bbc/peaks.js/commit/93c7024ccfccfbfa13de2addac644492fb2219cf - this fixes that and updates the types to cover the new options structure.

(Update: actually, overviewHighlightColor continued working as long as you specified both it and the overviewHighlightOffset. But it was no longer applying the default values for either, and they couldn't be specified via the new 'options.overview' option.)

chrisn commented 3 years ago

Thanks, I missed the highlight options when I wrote this. Updating the TypeScript definitions was on my list of things to do (code on master branch may well be unfinished work in progress...), so thanks for adding them!