search

bbc / peaks.js

JavaScript UI component for interacting with audio waveforms
https://waveform.prototyping.bbc.co.uk
GNU Lesser General Public License v3.0
3.2k stars 279 forks source link

Issue scrolling #430

Closed adamteale closed 2 years ago

adamteale commented 2 years ago

Hi!

Any ideas what would be causing the segments to not scroll along with the waveform when I drag/scroll along the waveform? When i hit play it seems to sort of work but isn't so smooth.

Using React & Typescript. Peaks.js 0.27.0

https://user-images.githubusercontent.com/7489774/145024108-70551438-275d-4941-999b-ce5f931262e8.mov

Thanks!

Adam

adamteale commented 2 years ago

I just tried v0.26.0 and it seems ok

chrisn commented 2 years ago

I'm not sure what's causing this, it's working OK for me here.

tmtakashi commented 2 years ago

Hi, this issue seems to happen when editable is set to false in my environment. Do you have any idea why this happen @chrisn ?

chrisn commented 2 years ago

Thanks @tmtakashi. I can reproduce the issue with editable: false. I'll investigate...

chrisn commented 2 years ago

I've just published a new version to npm that should fix this issue. Please update and let me know if it works OK for you.

tmtakashi commented 2 years ago

It seems to be working with editable: false with the update! Thanks for your fast response & fix!

chrisn commented 2 years ago

@adamteale I'll close this, as I'm hoping your issue is also fixed in v0.28.0, but please re-open if not.