search

bbc / peaks.js

JavaScript UI component for interacting with audio waveforms
https://waveform.prototyping.bbc.co.uk
GNU Lesser General Public License v3.0
3.16k stars 277 forks source link

feat(): highlight region styles #467

Closed jakiestfu closed 1 year ago

jakiestfu commented 1 year ago

BBC Team,

First off, thanks for this incredible library. Secondly, I apologize for not discussing this prior to the PR, but I hope this will be received well.

I have a strong desire to further visually customize Peaks.js. In this PR, the highlight region. Here is an example of my particular design usecase. Might be worth exploring a way to extend Konva options for every Konva object but honestly, this looks beautiful to me and I'm very happy with the ability to set these options.

Screen Shot 2022-10-12 at 8 10 04 AM
jakiestfu commented 1 year ago

@chrisn What is your interest in this? Thoughts?

chrisn commented 1 year ago

Very nice! Thank you for contributing. More customisation options are welcome, please raise issues with your ideas.

If you're OK with it, I may have some minor comments on the code itself.

jakiestfu commented 1 year ago

Thanks for the code review, @chrisn! I've addressed your comments. Let me know if there is anything else I can do!

jakiestfu commented 1 year ago

Thanks for merging, @chrisn! When will this be available on NPM?

chrisn commented 1 year ago

I have just published v2.1.0. Thanks again!