search

bbc / peaks.js

JavaScript UI component for interacting with audio waveforms
https://waveform.prototyping.bbc.co.uk
GNU Lesser General Public License v3.0
3.16k stars 275 forks source link

Relax konva version range #494

Closed jdelStrother closed 1 year ago

jdelStrother commented 1 year ago

Konva 9.0 / 9.1 have been working fine for us with peaks. How about relaxing the version range?

chrisn commented 1 year ago

Thanks! I was hesitating updating because of the "Migrate the npm package from ES back to CommonJS" in 9.0.0 - but if the Peaks.js builds still work then we should be fine.

jdelStrother commented 1 year ago

Yeah, the commonjs switch seemed a bit of a regression - the only real discussion I found on it was here: https://discord.com/channels/753274212814422176/755201767934918827/threads/1096466627287060592. But in practice it only increased our bundle size by 1.5kb, and not noticed any other issues in our webpack-based build with 9.x.