search

bbc / psammead

React component library for BBC World Service and more
https://bbc.github.io/psammead/
Other
320 stars 54 forks source link

Media indicator SVG stays dark on high contrast mode #786

Closed j-pendlebury closed 5 years ago

j-pendlebury commented 5 years ago

Describe the bug When using the high contrast mode on PC, and with colour preferences changed in Firefox, the media indicator SVG icon stays dark and it's hard to see.

image

To Reproduce Steps to reproduce the behaviour:

  1. Go to www.stage.bbc.com/igbo
  2. Go to Firefox preferences
  3. Look for the Language and Appearance section image
  4. Go to Colours
  5. Set override to Always
  6. Make sure "Use system colours" is not ticked
  7. Set colours to a black/dark background and text that can be read (something bright) image
  8. Go back to the Igbo front page - icons are now hard to see
  9. Also look at with a custom high contrast mode on PC

Expected behaviour Icon should be visible regardless of what colours you have selected

Screenshots Current: image

Expected: image (although should probably talk to Catharine and UX)

j-pendlebury commented 5 years ago

Will most likely require changes similar to https://github.com/bbc/psammead/pull/704 and https://github.com/bbc/psammead/pull/787

j-pendlebury commented 5 years ago

Check with UX that they're happy with the solution