Closed greenc05 closed 5 years ago
Refined by WS-FP pod
Note: for services that have scripts which are right-to-left, this should also have the attribute dir="ltr"
.
@greenc05 Looking at the services config files, the copyright text for most services appears as just © 2019
without the word BBC
. Should we make this uniform i.e dynamically add the word BBC to the services that don't have it?
@EinsteinCarrey I believe the word BBC is translated for several services - e.g. for Persian it is بی بی سی
@greenc05 I'd suggest that we should actually fully translate the numerals to use the numbers in the correct script, since we are doing so for dates, and Most Read numbers as well. I am not sure that it is required to enforce English around the BBC in the copyright.
e.g. currently on Persian: (Copyright symbol, 2019, BBC.)
With corrected numerals:
As a result, the lang attribute does not need adding.
@sareh I concur with fully translating the numerals.
My concern, however, is about the word BBC
which doesn't appear in the copyright text for some services such as Swahili, Hindi, Rusian, Serbian _etc.._.
. Should we introduce it dynamically?
I've asked Laura/UX to advise....
@EinsteinCarrey the BBC label is currently not translated but transliterated for non-Latin languages e.g. Russian BBC > Би-би-си
@sareh I agree, especially now that we have Persian numbers in the Most read components, it is worth using numbers in the correct script.
Having said that, in my opinion the Lang attribute should still be valid for Copyright, where you may not want to translate Copyright to Derecho de autor in Spanish. @greenc05
@sareh @laurapsn I've included these two screenshots from igbo
and russian
service respectively. Note that one has the word BBC
in the copyright text and the disclaimer while the other only has BBC
in the disclaimer.
(NB: I used google translate to display them in English)
@EinsteinCarrey Thanks for the examples you've included - yes there are inconsistencies within the translation text, which should be addressed first, so all services have the same structure of copyright symbol year BBC.
, then the separate disclaimer sentence.
Then after that, the work can be done.
@laurapsn - there needs to be the BBC
mentioned twice. Once is for the BBC.
in the © 2019 BBC.
. Then it is also needed for the Disclaimer sentence. e.g. for Russian it should be 'Би-би-си. Би-би-си не несет ответственности за содержание других сайтов.',
This then shows up online as © 2019 Би-би-си. Би-би-си не несет ответственности за содержание других сайтов.',
Following Laura's comment , I'll add the English language attribute around the copyright only since the numerals in the year will be translated.
~Blocked on simorgh/2667~
Is your feature request related to a problem? Please describe. The copyright text in the footer is always in English regardless of the service.
Describe the solution you'd like Add an English language attribute around this content.
<span lang="en-GB">© 2019 BBC.</span>
so the accessibility acceptance criteria is met "All content not in the main language of the page must have the correct lang attribute"Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
Testing notes The copyright information should be announced with an english accent when using a screen reader
Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc
Additional context Add any other context or screenshots about the feature request here.