bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.

https://www.bbc.com/thai

Other

1.38k stars 215 forks source link

WSTEAM1-1058: Update tick SVG to SUCCESS_CORE colour #11677

Closed Isabella-Mitchell closed 2 months ago

Isabella-Mitchell commented 2 months ago

Resolves JIRA WSTEAM1-1058 - A11y P1 - SVG Colour contrast too low

Overall changes

Applies updated SUCCESS_CORE colour to SVG tick

Code changes

Updates/ add SUCCESS_CORE to palette in the Theme provider
Applies colour to SVG tick via CSS.

Note this means the tick appears black without CSS. This the same as we do for the Live Label pulse and the brand SVG, so I think this is ok.

Testing

View Success state via storybook permalink
Check colour matches design
Check colour passes colour contrast check

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines