bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.

https://www.bbc.com/thai

Other

1.4k stars 222 forks source link

WSTEAM1-1048 Refine ARIA-Attributes for Uploader #11705

Closed emilysaffron closed 4 months ago

emilysaffron commented 4 months ago

Resolves JIRA WSTEAM1-1048

Overall changes

For each form field:

Toggle 'aria-required=true' on based on '!isValid && required' instead of just required Set 'aria-invalid=false' explicitly on initial load so that FireFox doesn't announce the validity of these fields.

Code changes

A bullet point list of key code changes that have been made.

Testing

List the steps used to test this PR.

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines