search

bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.
https://www.bbc.com/thai
Other
1.28k stars 211 forks source link

Enable renovate's `updateLockFiles` option #11710

Closed karinathomasbbc closed 1 month ago

karinathomasbbc commented 1 month ago

Overall changes

Enables the "updateLockFiles" option in the renovate app

When comparing logs for when renovate times out (takes 16 minutes to complete) vs when renovate was working (completed in ~30-40 seconds), I noticed the following

Broken:

DEBUG: Executing command (branch="renovate/all-patch")
{
  "command": "yarn install --mode=skip-build"
}

Working:

DEBUG: Executing command (branch="renovate/all-patch")
{
  "command": "yarn install --mode=update-lockfile"
}

According to the yarn CLI docs https://yarnpkg.com/cli/install, update-lockfile is used by apps such as renovate "to keep a lockfile up-to-date without incurring the full install cost."

amoore108 commented 1 month ago

This looks like its set to true by default anyway? https://docs.renovatebot.com/configuration-options/#updatelockfiles

karinathomasbbc commented 1 month ago

This looks like its set to true by default anyway? https://docs.renovatebot.com/configuration-options/#updatelockfiles

Uurgh so it is. I am struggling to figure out why it is running the skip-build option instead of the update-lockfile option...