bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.

https://www.bbc.com/thai

Other

1.28k stars 211 forks source link

WSTEAM1-972 - Uploader error screen #11727

Closed amoore108 closed 3 weeks ago

amoore108 commented 1 month ago

Resolves JIRA https://jira.dev.bbc.co.uk/browse/WSTEAM1-972

Overall changes

Adds ErrorScreen component
Sets page title to Error: {title} if the user lands on this screen
Adds Storybook story for error screen
Renames existing Form to FormScreen for naming consistency
Renames existing SuccessMessage to SuccessScreen for naming consistency
Unrelated fix to return correct page type for Webvitals as this was throwing console errors

Testing

Visit https://wsteam1-972-uploader-error-screen--5d28eb3fe163f6002046d6fa.chromatic.com/iframe.html?args=&id=pages-ugc-page--error-screen&viewMode=story
Confirm it renders correctly and aligns to a11y AAC / screen-reader guidelines
Check the page title starts with Error: (translations to follow)

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines