bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.

https://www.bbc.com/thai

Other

1.4k stars 222 forks source link

WSTEAM1-1083: Update validation function #11728

Closed shayneahchoon closed 3 months ago

shayneahchoon commented 3 months ago

Resolves JIRA WSTEAM-1083

Overall changes

Updates the validation functions to cover all expected use cases.

Code changes

ws-nextjs-app/pages/[service]/send/[id]/FormContext/utils/validateFunctions.ts updated to incorporate file validation logic.
ws-nextjs-app/pages/[service]/send/[id]/FormContext/index.tsx updated to propagate the validation data from the UGC api, so that this can be used by the validation functions.
Message codes added to match their respective morph translations.

Testing

List the steps used to test this PR.

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

shayneahchoon commented 3 months ago

Have merged into this one: WSTEAM1-1018-input-fields-error-ux, to reduce merge conflicts.