Open louisearchibald opened 2 weeks ago
Looks good 👍
I think ideally the parseAssetData
could be uplifted to TypeScript to avoid the type casts, as we'd need to cast for any other future uses of the functions in that file as well. If its too much overhead to do now then its something that could be addressed later.
Do we know why the TS errors suddenly started to occur? The updated files with TS fixes seem unrelated to the rambda changes, so I wonder if we do actually need them?
Its vague, but 0.29.0
seems to have added some support for types: https://github.com/ramda/ramda/releases/tag/v0.29.0
Resolves JIRA [1263]
Overall changes
Upgrades
ramda
to version0.30.1
and@types/ramda
to0.30.0
and fixes any failures and type errors as a result of the upgradeCode changes
ramda
dependency to0.30.1
, andtypes/ramda
to0.30.0
inpackage.json
pathEq
functions to fix errors and test failures.Testing
(to be tested via preview environment)
Coding Standards
Repository use guidelines