search

bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.
https://www.bbc.com/thai
Other
1.39k stars 219 forks source link

WSTEAM1-1152: Default browser checkbox renders on HC modes #11758

Closed Isabella-Mitchell closed 1 month ago

Isabella-Mitchell commented 2 months ago

Resolves WSTEAM1-1152 - Uploader Checkbox on Windows High Contrast mode and FireFox with colour preferences changed (For requirements/ possible temporary fix until we work on this ticket)

Overall changes

Uses default browser checkbox on High contrast modes

Before (A11y P2) ff- black tick windows-high-contrast-mode-crop

After (P2 fixed) Screenshot 2024-07-09 at 16 27 46 Screenshot 2024-07-10 115746 Screenshot 2024-07-10 115853

Code changes

Testing

Go to permalink URL: https://high-contrast-tick-quick-fix--5d28eb3fe163f6002046d6fa.chromatic.com/iframe.html?args=&id=pages-ugc-page--form&viewMode=story Visit on HC modes check the checkbox appears Visit on non HC modes check the checkbox UX is unchanged

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

greenc05 commented 2 months ago

Think we also need to remove the input after CSS as the back tick background image bleeds through, this is most noticable in WHC mode if you select the 'High contrast white' theme.

Isabella-Mitchell commented 2 months ago

Think we also need to remove the input after CSS as the back tick background image bleeds through, this is most noticable in WHC mode if you select the 'High contrast white' theme.

Good spot! This should be resolved.

greenc05 commented 2 months ago

Looking good thank you @Isabella-Mitchell