bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.

https://www.bbc.com/thai

Other

1.39k stars 219 forks source link

New media player on canonical Article/MediaArticle pages #11782

Closed amoore108 closed 2 days ago

amoore108 commented 1 month ago

Overall changes

Enables new media player on canonical versions of Article and MediaArticle pages
Removes logic and references to old navOnArticles toggle
Removes LegacyLivePageMediaPlayer as this isn't used anymore
Removes counterName from RequestContext as this value should come from EventTrackingContext

Code changes

Uses new media player component on canonical versions of Article / MediaArticle pages. AMP continues to use the existing/older component

Testing

Check ArticlePage http://localhost.bbc.com:7080/mundo/articles/c1xv2q1gewvo?renderer_env=test
Confirm the video plays correctly
Check MediaArticlePage http://localhost.bbc.com:7080/hausa/articles/cd6y2qqq3vxo?renderer_env=live
Confirm the video plays correctly
Check CPS http://localhost.bbc.com:7080/serbian/cyr/srbija-68707945?renderer_env=live
Confirm the video plays correctly
Check MAP http://localhost.bbc.com:7080/hausa/labarai-51622389?renderer_env=live
Confirm the video plays correctly
Check MAP - Live stream http://localhost.bbc.com:7080/arabic/media-49522519?renderer_env=live
Confirm the live video plays correctly with rewind controls

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines