bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.

https://www.bbc.com/thai

Other

1.39k stars 219 forks source link

WSTEAM1-1159: Uploader Text Input Enforced Colours Border Fix #11784

Closed HarveyPeachey closed 1 month ago

HarveyPeachey commented 1 month ago

Resolves JIRA WSTEAM1-1159

Overall changes

Adds a border for enforced colours mode on the text inputs of the uploader form

Code changes

Adds border colour using canvasText system colour for enforced colours
Removes browser applied defaul outline for enforced colours
Updates snapshots

Testing

Open Firefox or Edge on windows
Visit http://localhost:7081/somali/send/u130092370?renderer_env=test
Enables custom colours in firefox, or enable high contrast mode in windows
See text inputs using text colour as the border colour

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

greenc05 commented 1 month ago

Looking good just need to check on Windows High Contrast mode if someone hasn't then no need for test.