bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.
https://www.bbc.com/thai
Other
1.39k stars 219 forks source link

WSTEAMA-1243-p2 Media promos on home pages do not read well without CSS #11806

Closed Nabeel1276 closed 1 month ago

Nabeel1276 commented 1 month ago

Resolves JIRA WSTEAMA-1243

Before: image

After image

Code changes

Testing

  1. Visit the afrique home page
  2. Disable all CSS using Web developer chrome extension
  3. Locate media promos
  4. There should be a comma followed by a space before the word "duration"

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

Nabeel1276 commented 1 month ago

Thanks @Nabeel1276 are you please able to add a screen shot of the updated component without CSS to the PR?

Sure, do you mean the way the screenshot is in the ticket?

greenc05 commented 1 month ago

Thanks @Nabeel1276 are you please able to add a screen shot of the updated component without CSS to the PR?

Sure, do you mean the way the screenshot is in the ticket?

Yes please, though we may need to look at removing the comma after the word 'Duration' first if that is still here, on the ticket this is referenced here: 'I think the comma has been put in the wrong place after the word Duration, see screen shot.' The ticket isn't very well written, sorry about that.

Nabeel1276 commented 1 month ago

Thanks @Nabeel1276 are you please able to add a screen shot of the updated component without CSS to the PR?

Sure, do you mean the way the screenshot is in the ticket?

Yes please, though we may need to look at removing the comma after the word 'Duration' first if that is still here, on the ticket this is referenced here: 'I think the comma has been put in the wrong place after the word Duration, see screen shot.' The ticket isn't very well written, sorry about that.

Not a problem, I have removed the redundant comma and added the screenshot of the media promo with the correct changes.