bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.

https://www.bbc.com/pidgin

Other

1.42k stars 225 forks source link

JumpTo - Remove `aria-labelledby` and add `border`s #12158

Closed amoore108 closed 1 week ago

amoore108 commented 1 week ago

Overall changes

Removes aria-labelledby attributes as these are not needed
Adds border to create the red bar indicator, rather than backgroundColor so that this still appears with forced-colours
Adds transparent border around wrapper so that the component is clearly visible on forced-colours

Testing

Visit http://localhost:7080/hindi/articles/c3vl5kzd744o?renderer_env=live in a browser with forced colours
Interact with a link on the JumpTo component
Confirm the bar indicator still appears
Confirm that there is a border around the component

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines