bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.

https://www.bbc.com/pidgin

Other

1.42k stars 225 forks source link

WSTEAMA-1444 - Remove election banner Optimizely references #12172

Closed louisearchibald closed 1 week ago

louisearchibald commented 1 week ago

Resolves JIRA [1444]

Overall changes

Removes experiment code added from Election Banner experiment that was previously run.

Code changes

Code removals and a test update to reinstate code as it was prior to the experiment.

karinathomasbbc commented 1 week ago

Was it not possible to revert https://github.com/bbc/simorgh/pull/12128 (scroll down to when it was merged & you can click the "Revert" button) or does this PR contain other changes?

louisearchibald commented 1 week ago

Was it not possible to revert #12128 (scroll down to when it was merged & you can click the "Revert" button) or does this PR contain other changes?

@karinathomasbbc Yes it would have been 🙈 we'd cut the branch and were nearly done by the time the penny dropped yesterday, doh 🤦‍♀️

karinathomasbbc commented 1 week ago

Was it not possible to revert #12128 (scroll down to when it was merged & you can click the "Revert" button) or does this PR contain other changes?

@karinathomasbbc Yes it would have been 🙈 we'd cut the branch and were nearly done by the time the penny dropped yesterday, doh 🤦‍♀️

Aw that's fair enough, but it now means that you know where to make all the changes for a new experiment!