Closed 12 closed 5 years ago
~Duplicate of https://github.com/bbc/simorgh/issues/1567~
No it's not @dr3. This is still the Gregorian calendar, #1567 is to investigate non-Gregorian (Jalili) calendars. We still need to translate the Gregorian calendar to Farsi.
Use Eastern Arabic numerals (possibly returned when using moment's fa locale)
In that case, this is true :) and Eastern Arabic numerals will be done in https://github.com/bbc/simorgh/issues/1663
@rhell please could you expand on 'Have onscreen and offscreen translations in Farsi for Updated text'? What are the offscreen requirements??
@greenc05 I think I was referring to the relative timestamp e.g. Updated 25 mins ago
. Looking at our UX though I can't see any notes for offscreen text... I'll try and remember what I meant here 😛
When these two fields are updated in the local fixture data, We get time updated in English instead of in Farsi which is the expected output.
"lastPublished": 1535122662000,
"lastUpdated": 1535122662000,
Duplicate of https://github.com/bbc/psammead/issues/1161 https://github.com/bbc/psammead/pull/1067 fixes this issue
Is your feature request related to a problem? Please describe. We need to update our Gregorian timestamps to support Persian, this includes using different numerals and right-to-left support.
Describe the solution you'd like When viewing an article in Persian, the timestamp should:
fa
locale) e.g. ۱۸ ژوئن ۲۰۱۹Updated
textDescribe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
Testing notes Regression on timestamps in News/Persian. Checking with someone who reads Persian whether the date is correct.
Dev insight: Cypress and unit tests with updated snapshots should ensure translations are correct.
Additional context Add any other context or screenshots about the feature request here.