search

bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.
https://www.bbc.com/thai
Other
1.4k stars 224 forks source link

Pass locale correctly to Gregorian timestamps in Arabic. #3183

Closed RayNjeri closed 5 years ago

RayNjeri commented 5 years ago

Is your feature request related to a problem? Please describe. We need to update our Gregorian timestamps to support Arabic, this includes using its translations, different numerals for Arabic, and right-to-left support.

We already completed this work for Persian in https://github.com/bbc/simorgh/issues/1969 and Urdu in https://github.com/bbc/simorgh/pull/3131 so this issue should be extending that further to encompass the requirements for the Arabic service in this group.

Describe the solution you'd like When viewing an article in Arabic, the timestamp should: Use Western Arabic numerals (i.e. 12345678...) (possibly returned when using moment's ur locale) Be right-to-left Have onscreen and offscreen translations in Arabic for Updated text When time is updated, the updated timestamps should all read in Arabic

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Testing notes We will want to test that the timestamp returns as expected depending on the locale that's being passed through. We may also want to investigate if there are any changes we want to make to the Cypress tests given we're introducing extra logic to the timestamp. This needs to have e2e coverage.

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

Additional context Add any other context or screenshots about the feature request here.

rhenshaw56 commented 5 years ago

should be picked unblockedd once https://github.com/bbc/psammead/issues/1778