search

bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.
https://www.bbc.com/pidgin
Other
1.41k stars 224 forks source link

Add / Validate Translations for MAP v1 Services #4681

Closed ryanmccombe closed 4 years ago

ryanmccombe commented 5 years ago

Is your feature request related to a problem? Please describe. Add required translations for our v1 services:

Describe the solution you'd like We need to ensure we have the correct translations for these services :

Please refer to the translations spreadsheet - pinned in the media pod channel

Describe alternatives you've considered N/A

Testing notes [Tester to complete]

Dev insight: Should we add cypress tests to all services for this?

Additional context Add any other context or screenshots about the feature request here.

aeroplanejane commented 4 years ago

@ryanmccombe if you can show me where these configs are stored in Simorgh then I can validate

aeroplanejane commented 4 years ago

Nm - there's another issue for related content! This has been done for our first 5 services but I won't be tracking this through github

ryanmccombe commented 4 years ago

Only assigned it to you because it was moved into in progress

If the translations are in the spreadsheet, we still need to move them into Simorgh - that's what this issue was for

ryanmccombe commented 4 years ago

These seem good to me as they are - ready for testing

https://docs.google.com/spreadsheets/d/1blHrKE_CGnEKuCqj7pqR-rylUIVbxgkl64f5LEHv6LE/edit#gid=0

LilyL0u commented 4 years ago

Pidgin link 'Why you fit trust BBC News' shoud go to https://www.bbc.com/pidgin/institutional-48528766 (in Pidgin language), but actually goes to https://www.bbc.co.uk/news/help-41670342 (in English Language).

This is also happening with Igbo and Yoruba.

LilyL0u commented 4 years ago

If the URL is bbc.com/pidgin/ Then if I add /media-511121201 to the end, which is a non-existent page (just changed the last number), should that have the Pidgin 404 error translations? Currently when I do that, it is in english as below:

Image 17-01-2020 at 11 28

This is also happening with igbo.

ryanmccombe commented 4 years ago

This seems to be an issue with the routing refactor - not with the translations.

Translations are there, but the request isn't reaching Simorgh - it's just hitting a Mozart error page that is using Simorgh's design

Conversation in Mozart's slack: https://bbcnews.slack.com/archives/C2BU2N4TH/p1579279652055500

LilyL0u commented 4 years ago

Will test Thai, Punjabi, Afaan Oromoo, Amharic, Tigrinya, Marathi, Telugu, Gujarati when they are on test