bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.
https://www.bbc.com/thai
Other
1.39k stars 220 forks source link

Error in Video Object Schema on Persian Live Stream #5708

Closed aeroplanejane closed 4 years ago

aeroplanejane commented 4 years ago

Describe the bug There are errors in the video object schema on the Live Stream Pages. This can affect google's ability to index these pages as video.

To Reproduce Steps to reproduce the behaviour:

  1. Go to https://search.google.com/structured-data/testing-tool/
  2. Test this Persian Live TV URL: https://www.bbc.com/persian/media-49522521
  3. Note the errors in the video object with the name, description thumbnail URL

Screenshot 2020-02-28 at 12 01 26

This is where it's being rendered within the html:

Screenshot 2020-03-03 at 15 52 47

Expected behaviour The video object should have no errors. See the PAL example of the live stream: http://pal.test.bbc.com/persian/media-49522521 See a clip example on Simorgh: https://www.bbc.com/pidgin/media-44221514

Live stream assets on Simorgh TEST: https://www.test.bbc.com/pidgin/media-23256547 https://www.test.bbc.com/pidgin/media-23256548 https://www.test.bbc.com/pidgin/media-23256549 https://www.test.bbc.com/pidgin/media-23256550 https://www.test.bbc.com/pidgin/media-23256552 https://www.test.bbc.com/pidgin/media-23256553 https://www.test.bbc.com/pidgin/media-23256554

Live stream assets on LIVE: (PAL) https://www.bbc.com/arabic/media-49522519 (PAL) https://www.bbc.com/hindi/india-48336189

Additional context

Resources

karinathomasbbc commented 4 years ago

There is a Chrome extension for structured data testing meaning you can test this locally - Structured Data Testing Tool - https://chrome.google.com/webstore/detail/structured-data-testing-t/kfdjeigpgagildmolfanniafmplnplpl

aeroplanejane commented 4 years ago

@RichardPK We need to change the name and description from ares.media.caption to ares.promos.headlines.headline for CPS MAPs with Live Streams. According to editorial this field is optional on CPS on live. In order to avoid issues with videoObject name and description in the future we should use headline field. This could also be used for TC2 MAP assets. cc @gavinspence @graemelindsayBBC