bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.
https://www.bbc.com/thai
Other
1.39k stars 218 forks source link

Add Linked data to IDX page #6621

Closed thekp closed 4 years ago

thekp commented 4 years ago

Is your feature request related to a problem? Please describe. We currently have an IDX skeleton page and need to add Linked Data to this page.

Describe the solution you'd like

The linkedData currently has props of:

LinkedData.propTypes = {
  showAuthor: bool,
  type: string.isRequired,
  seoTitle: string.isRequired,
  headline: string,
  description: string,
  datePublished: string,
  dateModified: string,
  aboutTags: arrayOf(
    shape({
      '@type': string,
      name: string,
      sameAs: arrayOf(string),
    }),
  ),
};

We should pass the same props as what the FrontPage does (type and seoTitle). The seoTitle should be the meta title.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Testing notes [Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

Additional context Add any other context or screenshots about the feature request here.

Bopchy commented 4 years ago

Blocked on pageData being available - https://github.com/bbc/simorgh/issues/6413