search

bbc / speculate

Automatically generates an RPM Spec file for your Node.js project
Other
66 stars 28 forks source link

Service file unit options #53

Closed dantailby closed 6 years ago

dantailby commented 6 years ago

Adding ability to specify Unit options for the generated .service file

If no options are specified it will maintain existing behaviour so not to affect existing projects.

dantailby commented 6 years ago

@DaMouse404 Are you able to review this? We keen to make the build changes on our end given this goes ahead.

Mousius commented 6 years ago

@dantailby, trying to think of the best line in the docs to explain it defaults After if you don't pass any values: https://github.com/bbc/speculate/pull/53/files#diff-b7bc7a52e1da38f1bf719a0a8c3c6f31R7

If you quickly update the docs I can merge and release today 😄

dantailby commented 6 years ago

Done 👍