search

bbc / speculate

Automatically generates an RPM Spec file for your Node.js project
Other
66 stars 28 forks source link

Switched from hogan.js to handlebars #69

Closed njh closed 5 years ago

njh commented 5 years ago

There have been no commits to hogan.js for ~4 years We are also using handlebars in a lot of other projects.

I had to make a couple of changes to the templates to make them compatible with handlebars. Thank goodness for the tests.

njh commented 5 years ago

Another bonus is it seems to have reduced the number of second-level dependencies

UsainBloot commented 5 years ago

Looks good to me, should we release this as v2.0.0 along with these security fixes?

https://github.com/bbc/speculate/pull/72 https://github.com/bbc/speculate/pull/71 https://github.com/bbc/speculate/pull/70 https://github.com/bbc/speculate/pull/68

njh commented 5 years ago

Sounds like an excellent idea