bbc / wraith

Wraith — A responsive screenshot comparison tool
http://bbc-news.github.io/wraith/
Apache License 2.0
4.84k stars 356 forks source link

Make a `javascript_enabled` property #336

Closed ChrisBAshton closed 8 years ago

ChrisBAshton commented 8 years ago

We have a phantom--nojs file just sitting there, not useful to anybody in particular.

People can manually trigger the noJS mode of Phantom or Casper through the before_capture hook, or specify their own nonJS snap file. But it would be nice if we offered a dedicated option in the YAML file (javascript_enabled: true or false. true by default).

ChrisBAshton commented 8 years ago

No longer valid. The changes this would require under the hood are too unclean (we're already passing too many arguments to the command line than is advised for maintainability!) and this can be easily accomplished using the beforeCapture hook.

I've added some clear examples for achieving this, which can be retrieved by running wraith setup: https://github.com/BBC-News/wraith/commit/b0f1aaee13d8162bdc59c4170ada6ba5c7ba7fb7