Update buttons for IE10

bbcmicrobit / PythonEditor

A MicroPython editor for the BBC micro:bit that works with browsers.

https://python.microbit.org/

MIT License

198 stars 130 forks source link

Closed microbit-josephine closed 5 years ago

microbit-carlos commented 5 years ago

@microbit-henry to test on IE10 and IE11 VMs and firefox inside one of the Windows VMs.

microbit-carlos commented 5 years ago

@microbit-josephine Could you include a before and after screenshot in this PR, will make the reviewing easier.

microbit-josephine commented 5 years ago

Before: Screenshot 2019-10-21 at 11 48 12

After: Screenshot 2019-10-21 at 11 43 25

microbit-carlos commented 5 years ago

@microbit-josephine Are those screenshots for IE10 or Firefox on Windows? What's the difference between this PR and https://github.com/bbcmicrobit/PythonEditor/pull/272 ?

microbit-josephine commented 5 years ago

yes Ive put the wrong screen shots! these are meant to be with #272 . I have updated them now

microbit-carlos commented 5 years ago

Great, have you tested this as well in IE11?

@microbit-henry can you please review and test in IE10, IE11, Chrome, Safari and Firefox?

microbit-josephine commented 5 years ago

No, browser stack only shows up to ie10 unfortunately

microbit-carlos commented 5 years ago

I'm sure there must be a way to test IE11 in Browser stack, did you look into different versions of windows?