bbcmicrobit / PythonEditor

A MicroPython editor for the BBC micro:bit that works with browsers.
https://python.microbit.org/
MIT License
198 stars 130 forks source link

Target and render icons in Firefox #275

Closed microbit-josephine closed 5 years ago

microbit-carlos commented 5 years ago

@microbit-josephine Could you include a before and after screenshot in this PR, will make the reviewing easier.

microbit-josephine commented 5 years ago

Before: firefox-before After: firefox-after

microbit-carlos commented 5 years ago

@microbit-henry what browsers was this tested on?

microbit-henry commented 5 years ago

@microbit-carlos I tested it in windows firefox, IE10 and IE11. All the buttons worked in firefox, only the buttons that were too low were fixed in IE10 and none of the buttons were fixed in IE11. But I assumed this wasn't an issue because this was a PR specifically for fixing the buttons in windows firefox