bbcmicrobit / PythonEditor

A MicroPython editor for the BBC micro:bit that works with browsers.
https://python.microbit.org/
MIT License
196 stars 130 forks source link

Fix issue downloading Python Script in Safari. #298

Closed microbit-carlos closed 4 years ago

microbit-carlos commented 4 years ago

It also only limits the "safari bug" workaround to only execute in Safari < v10.

microbit-carlos commented 4 years ago

@microbit-josephine could you test this in macOS Safari 6, 9 and 10, and Windows IE10?

To test this PR we need to do 3 things:

Apart from that in Safari 6 and and 9 (but not in Safari 10!) I expect this alert to show up the file default name not to be the project name (it'll be something like "unknown" or "untitled" instead of "microbit_program"). However, the file contents should still be correct:

image

microbit-josephine commented 4 years ago

There were limitations to what I could check, as I couldn't open the files in safari to check them. However, the warning messages did come up for safari 9 and 6 and the files were saved as unknown. The warning didn't appear for safari 10 or IE10 and they were named microbit_program. For IE10 the files opened fine and as expected.

microbit-carlos commented 4 years ago

Thanks Josephine, I've forced the download with the alert in Safari 13 via debugger and confirm that the files work using that method.