search

bbcmicrobit / PythonEditor

A MicroPython editor for the BBC micro:bit that works with browsers.
https://python.microbit.org/
MIT License
196 stars 130 forks source link

Python Editor A11y Axe CI testing fixes #303

Closed microbit-mark closed 4 years ago

microbit-mark commented 4 years ago

https://github.com/microbit-foundation/platform-software-issue-tracker/issues/409 raised a couple more issues that need to be addressed. Fixes https://github.com/microbit-foundation/platform-software-issue-tracker/issues/567 Fixes https://github.com/microbit-foundation/platform-software-issue-tracker/issues/528 and Fixes https://github.com/microbit-foundation/platform-software-issue-tracker/issues/566

microbit-carlos commented 4 years ago

Since we are touching CSS that affects multiple browsers we need to test this everywhere before releasing or we might accidentally introduce some regressions.

@microbit-josephine could you check that this PR hasn't changed the formatting of the buttons (especially the small buttons) in IE10, IE11, Edge, Firefox Windows, Firefox macOs, and Chrome?

You can compare it with https://python-editor-2-0-0.microbit.org/ side-to-side, or switching tabs back and forth is a good way to spot any minor differences.

@microbit-mark can you walk Josephine through the changes in this PR so she knows what to look for?

microbit-mark commented 4 years ago

@microbit-carlos I did cross browser testing at this commit https://github.com/bbcmicrobit/PythonEditor/pull/303/commits/b0cbe5879e952d46a8bd7d354e2635a02cfb9800 and didn't find issues, but it would be good to get another pair of eyes on it.

microbit-carlos commented 4 years ago

Yes, but by changing from IDs to classes it has affected the order of precedence, so it is possible there might be other issues like the padding.

microbit-josephine commented 4 years ago

@carlosperate @microbit-mark I have checked updates in IE10, IE11, Edge, Firefox Windows, Firefox macOs, and Chrome and all looks alright (like https://python-editor-2-0-0.microbit.org/ ).

microbit-carlos commented 4 years ago

In small resolutions as well?

microbit-josephine commented 4 years ago

Yes, I have now checked them all in small resolutions as well.