search

bbcmicrobit / PythonEditor

A MicroPython editor for the BBC micro:bit that works with browsers.
https://python.microbit.org/
MIT License
197 stars 130 forks source link

A11y: Modal close "button" should be keyboard focusable #355

Open microbit-carlos opened 3 years ago

microbit-carlos commented 3 years ago

We can't focus the "x" close button via keyboard:

Screenshot 2020-11-17 at 15 05 07

We can still close the modal via escape key: https://github.com/bbcmicrobit/PythonEditor/pull/310

We could fix this via workaround, or if the modal library get's a fix upstream: https://github.com/HubSpot/vex/pull/134

More info in https://github.com/bbcmicrobit/PythonEditor/issues/347#issuecomment-728986198