search

bbcmicrobit / micropython

Port of MicroPython for the BBC micro:bit
https://microbit-micropython.readthedocs.io
Other
603 stars 284 forks source link

Make shell command explicit for version file creation #658

Closed WayneKeenan closed 3 years ago

WayneKeenan commented 5 years ago

Fix for #657

WayneKeenan commented 5 years ago

also applies for #656

dpgeorge commented 5 years ago

Thanks for the PR. I think we can eliminate completely the need for the "echo -n" by calling adduicr.py as follows:

tools/adduicr.py $(HEX_SRC) 0x$$(cat $(VER_ADDR_FILE)) -o $(HEX_FINAL)

Note the addition of "0x" before cat'ing VER_ADDR_FILE. I'd prefer this approach because it's simpler, can you please update the PR?

dpgeorge commented 3 years ago

Updated as above and merged in dc92faf91be4cdf74130ec9144a5e5ba02d3836d